Feature/lsd fix #83
Merged
Feature/lsd fix #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th projects are in the Source directory and not yet included in the solution. Tests are added back in Tests. Still need to Add the LinkSet Data tests and activate them in the solution.
…th projects are in the Source directory and not yet included in the solution. Tests are added back in Tests. Still need to Add the LinkSet Data tests and activate them in the solution.
…ue so it doesnt need to be calculated. We make the size a required field so we can tell if its not present and fall back to handling the old format as well. Make the serialized fields writable publically so they can be deserialized successfully. This is a change in dotnet 8.
…uatch into feature/lsd-fix
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…and rename some generated code for the Search tables ef core support away from Object which is of course a reserved word.
|
This changeset really should have been split but I had committed and pushed the EF Core and placeholder AISv3 service earlier while I was hunting for the reason for the LSD failure. I won't do it this way in the future, instead breaking things up into separate changesets. Addressed all CodeQL comments. Should be good to go. Tested on Beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to fix deserialization of LinkSetData using JsonSerialization under dotnet8. Setters now need to be public for deserialization to work.